aprantl marked an inline comment as done. aprantl added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:135 + ifeq "$(TRIPLE_ENV)" "" + CODESIGN := codesign + endif ---------------- vsk wrote: > If I've read this correctly, this means we'll only sign when `TRIPLE_OS == > "macosx" && TRIPLE_ENV == ""`. Is that what we want, or should we be signing > everything? This is preserving the old behavior, and IIUC code signing on macOS is just slowing things down with no advantage. ================ Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:143 + ifeq "$(TRIPLE_VERSION)" "" + TRIPLE_VERSION := $(shell echo $(notdir $(SDKROOT)) | grep -E -o -e '[0-9]+\.[0-9]') + endif ---------------- vsk wrote: > Can we just write `xcrun --sdk $(SDK_NAME) --show-sdk-version`? > > If not, is the "-e" option to grep redundant, since there's only one pattern > to match? Yes, that's nicer! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81980/new/ https://reviews.llvm.org/D81980 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
