labath added a comment. Sounds like a good idea, just the error handling needs to be done carefully.
================ Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:171 + if (!nullin) { + error = nullin.takeError(); + return; ---------------- I'm pretty sure this will trigger an assertion about overwriting an unchecked error. One way to handle this would be to wrap the error in an `ErrorAsOutParameter` object, but I think it's better to replace the constructor with a static factory function returning an `Expected<unique_ptr>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82396/new/ https://reviews.llvm.org/D82396 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits