labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:77 + io_redirect_or_error = + options.GetEnableIO() + ? ScriptInterpreterIORedirect::Create(m_debugger, result) ---------------- I wonder if we should just pass `options.GetEnableIO()` to the factory function, and let it figure out the details... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82412/new/ https://reviews.llvm.org/D82412 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
