rovka added a comment. Hi Omair,
If this is intended to be more generally useful, I wonder if we should rename it to something else (e.g. lldb-qemu-howto.txt) and only use AArch64 SVE as a case study. In any case, thanks for writing this up! ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:5 + +QEMU can be used to test LLDB in emulation environment in absence of actual +hardware. This write up will help setup an QEMU environment for testing LLDB ---------------- Nitpick: "in **an** emulation environment in **the** absence of actual [...] ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:7 +hardware. This write up will help setup an QEMU environment for testing LLDB +patches supporting AArch64 features like SVE, MTE, Pointer Authentication etc. + ---------------- Isn't this guide still useful after the patches are merged? ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:9 + +Ubuntu Bionic/Focal x86_64 host machine was used to test all instruction in this +document. Please update it according to your host distribution/architecture. ---------------- Typo: all the instructions ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:19 +################################################################################ +#!/bin/bash + ---------------- Would it be better for this to be an actual script in lldb/utils or somewhere similar? ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:78 +# +# Build QEMU from source for AArch64 system-mode emulation +################################################################################ ---------------- Is this difficult to infer from QEMU's own docs? If not, maybe just add a link and mention only what's specific to this guide (I'm guessing the target-list). ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:96 +# +# Cross compile Linux kernel +################################################################################ ---------------- Same as above, could this be just a link to the official docs? ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:124 +################################################################################ +#!/bin/bash + ---------------- Same as step 1: can this live in utils? ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:176 +# Your default username will be the one with whom you created RootFS image. +# Internet access inside your emulation environment run: sudo dhclient enp0s2. +################################################################################ ---------------- Nitpick: **For** Internet access [...] ================ Comment at: lldb/docs/lldb-qemu-aarch64-sve-howto.txt:217 + +# Cross compile LLDB server for AArch64 Linux +# Transfer LLDB server executable to emulation environment ---------------- For consistency, maybe there should be some commands here, or a link to the docs for cross-compiling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82064/new/ https://reviews.llvm.org/D82064 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
