teemperor accepted this revision. teemperor added a comment. LGTM, thanks!
================ Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2537 + def assertSuccess(self, obj, msg=None): + if not obj.Success(): + error = obj.GetCString() ---------------- JDevlieghere wrote: > I'm not actually sure this works for custom types, but should we add an > `assert isinstance(obj, lldb.SBError)` to avoid misuse? I actually also wondered if `obj` can be anything else in LLDB's SB API. I guess it's Pythonic to allow anything that fits that signature but some one-line documentaiton that this intended is for SBError would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82759/new/ https://reviews.llvm.org/D82759 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
