labath accepted this revision.
labath added a comment.

Thanks. If you think this is worth cherry-picking to 11.0 (it sounds like it 
is), please file the appropriate bug.



================
Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbol.yaml:104
     StorageClass:    IMAGE_SYM_CLASS_STATIC
+  - Name:            .file
+    Value:           0
----------------
Maybe a comment that says this checks that the symbol is skipped. (making sure 
this code is not later removed for being unused).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84070/new/

https://reviews.llvm.org/D84070



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to