jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land.
I think you missed two more places to pass a target, then this looks good to me. How tedious, thanks for doing it... ================ Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1666 + typedefed_type_sp->GetDescription(&strm, eDescriptionLevelFull, true, + nullptr); typedef_type_sp = typedefed_type_sp; ---------------- You should be able to use the same target here that you did just above, right? ================ Comment at: lldb/source/Commands/CommandObjectTarget.cpp:1710 typedefed_type_sp->GetFullCompilerType(); - typedefed_type_sp->GetDescription(&strm, eDescriptionLevelFull, true); + typedefed_type_sp->GetDescription(&strm, eDescriptionLevelFull, true, + nullptr); ---------------- Here too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84267/new/ https://reviews.llvm.org/D84267 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits