logan-5 added a comment.

In D84126#2171469 <https://reviews.llvm.org/D84126#2171469>, @labath wrote:

> Instead of adding -Wno-suggest-override to every user it might be cleaner to 
> add the flag to the INTERFACE_COMPILE_OPTIONS property of the relevant 
> targets (gtest, gmock, and gbenchmark ?). That way, anything which links 
> against these will inherit it automatically.


Thanks, that's a good idea -- I'll look into that as a follow-up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84126/new/

https://reviews.llvm.org/D84126



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to