jingham added inline comments.
================ Comment at: lldb/source/Target/TargetList.cpp:245 } + error_strm.Printf("), specify an architecture to disambiguate"); + error.SetErrorString(error_strm.GetString()); ---------------- jingham wrote: > I'm not sure why you removed mention of --platform from this error because > with this patch it should now be possible to disambiguate either by > specifying --platform or --arch, right? Ah, okay I didn't see that the platform doesn't get used everywhere in this patch. ================ Comment at: lldb/test/API/commands/target/basic/bogus.yaml:945 + Values: [] + debug_line: + - Length: 39 ---------------- jingham wrote: > You don't use the debug info, might as well leave it out. Done... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84809/new/ https://reviews.llvm.org/D84809 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits