JDevlieghere added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:1043 + if configuration.suite.countTestCases() == 0: + print("error: did not discover any tests.") + exitTestSuite(1) ---------------- MaskRay wrote: > JDevlieghere wrote: > > Maybe `did not discover any (matching) tests` to make it clear that this > > might be the result of user input? > `sys.stderr.write` or `print(..., file=sys.stderr)` (which appends a newline) > > Trailing full stops are not recommended for error messages if the project > does not already have the convention > http://llvm.org/docs/CodingStandards.html#error-and-warning-messages > > Looking around, several messages do not have a full stop. Let's use `logging.error` like the other error messages if we want this to go to stderr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85169/new/ https://reviews.llvm.org/D85169 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits