JDevlieghere added inline comments.

================
Comment at: lldb/source/Target/Target.cpp:3918
+  if (Module *exe_module = m_target->GetExecutableModulePointer())
+    m_launch_info.SetExecutableFile(exe_module->GetPlatformFileSpec(), true);
   m_launch_info.SetArg0(GetArg0()); // FIXME: Arg0 callback doesn't work
----------------
Unfortunately doing this here doesn't work. Some of the code that's using 
`GetProcessLaunchInfo()` depends on the assumption that the `m_arguments` list 
in `ProcessInfo` does not contain argv[0], while other code, most notably the 
code to actually launch a binary, depends on it being the first argument. So 
whatever I do here, I break some code. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85235/new/

https://reviews.llvm.org/D85235

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to