Author: Jim Ingham Date: 2020-08-05T19:02:00-07:00 New Revision: 08063f85a7eadb1e54d0a03e0307bf15319513e8
URL: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8 DIFF: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8.diff LOG: "|" used when "||" was meant in SBTarget::FindFunctions Added: Modified: lldb/source/API/SBTarget.cpp lldb/test/API/python_api/target/TestTargetAPI.py Removed: ################################################################################ diff --git a/lldb/source/API/SBTarget.cpp b/lldb/source/API/SBTarget.cpp index 04540a2fab43..34cab6217565 100644 --- a/lldb/source/API/SBTarget.cpp +++ b/lldb/source/API/SBTarget.cpp @@ -1791,7 +1791,7 @@ lldb::SBSymbolContextList SBTarget::FindFunctions(const char *name, (const char *, uint32_t), name, name_type_mask); lldb::SBSymbolContextList sb_sc_list; - if (!name | !name[0]) + if (!name || !name[0]) return LLDB_RECORD_RESULT(sb_sc_list); TargetSP target_sp(GetSP()); diff --git a/lldb/test/API/python_api/target/TestTargetAPI.py b/lldb/test/API/python_api/target/TestTargetAPI.py index 5bdbf90b3575..7db53883eb6a 100644 --- a/lldb/test/API/python_api/target/TestTargetAPI.py +++ b/lldb/test/API/python_api/target/TestTargetAPI.py @@ -283,6 +283,10 @@ def find_functions(self, exe_name): target = self.dbg.CreateTarget(exe) self.assertTrue(target, VALID_TARGET) + # Try it with a null name: + list = target.FindFunctions(None, lldb.eFunctionNameTypeAuto) + self.assertTrue(list.GetSize() == 0) + list = target.FindFunctions('c', lldb.eFunctionNameTypeAuto) self.assertTrue(list.GetSize() == 1) _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
