vsk added a comment. I gave this another look-over, and while I didn't spot anything troubling, I'm not terribly familiar with this code. I'll give this a third pass later today if review is still needed.
================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:558 + "arm64e-apple-ios-simulator", "arm64-apple-ios-simulator", + "x86_64-apple-ios-simulator", "x86_64h-apple-ios-simulator", +#else ---------------- aprantl wrote: > vsk wrote: > > Can we get into a bad state here when initializing lldb on an embedded > > device? > Good question. I think the pragmatic answer here is that we won't encounter > simulator binaries on an embedded device and that the platform will refuse to > launch a simulator if one doesn't exist. All the same, just in case we need to introduce mac-specific code in the future, it may be more convenient to write this as `#if TARGET_OS_MAC == 1 && TARGET_CPU_ARM == 1` (hope I've spelled that correctly!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85243/new/ https://reviews.llvm.org/D85243 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
