JDevlieghere added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:824
+ while (retry and error.Fail() and
+ isinstance(error.GetCString(), six.string_types) and
+ "Unable to boot the Simulator" in error.GetCString()):
----------------
Why is this necessary? Is there an error case where `error.GetCString` is not a
python string? If so we should probably factor this out in a function and do
the `if sys.version_info.major == 2: str.decode('utf-8', 'replace')` trick
instead because otherwise the retry won't kick in.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85542/new/
https://reviews.llvm.org/D85542
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
