vsk added inline comments.

================
Comment at: lldb/cmake/modules/LLDBFramework.cmake:6-37
+if(NOT APPLE_EMBEDDED)
+  set_target_properties(liblldb PROPERTIES
+    FRAMEWORK ON
+    FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}
 
-  OUTPUT_NAME LLDB
-  VERSION ${LLDB_VERSION}
-  LIBRARY_OUTPUT_DIRECTORY ${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}
+    OUTPUT_NAME LLDB
+    VERSION ${LLDB_VERSION}
----------------
JDevlieghere wrote:
> I //think// you should be able to do this. 
I've tried factoring out the value for the VERSION property in the past and, if 
memory serves, this resulted in an unusable framework on iOS. I'd rather hold 
off on this for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85770/new/

https://reviews.llvm.org/D85770

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to