labath added a comment.

Looking at the dependent patch, I see that you need to conjure up a fake 
register set to make this work. That works, but doesn't seem entirely optimal. 
This expedition function doesn't really care about register sets, it just needs 
a way to get a list of registers. What if we just made the interface return 
that? (e.g. `ArrayRef<uint32_t> GetExpeditedRegisters()`)

And instead of handing the nullptr specially in the caller, we could just make 
the default implementation of this function return the first (zeroth) register 
set...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82853/new/

https://reviews.llvm.org/D82853

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to