teemperor added a reviewer: JDevlieghere. teemperor added a comment. Thanks for working on this! This looks good to me, but I wonder if doing this with a dedicated flag instead of an environment variable would be better. But I'll leave that to the others who have a better idea how the dotest flags should work.
Out of curiosity, will this also fix the TestPluginCommands.py ? ================ Comment at: lldb/test/API/lit.site.cfg.py.in:23 config.python_executable = "@Python3_EXECUTABLE@" +config.libcxx_used = @LLVM_LIBCXX_USED@ config.dotest_path = "@LLDB_SOURCE_DIR@/test/API/dotest.py" ---------------- Maybe move this below the `config.llvm_use_sanitizer` line, as this is currently in the middle of the python/dotest.py-related config flags. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 _______________________________________________ lldb-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
