jasonmolenda added a comment. In D86667#2243878 <https://reviews.llvm.org/D86667#2243878>, @labath wrote:
> In D86667#2243781 <https://reviews.llvm.org/D86667#2243781>, @mib wrote: > >> In D86667#2242566 <https://reviews.llvm.org/D86667#2242566>, @jingham wrote: >> >>> Do people really call command-line shells interpreters? I would have >>> thought --shell would be a better name. lldb already has its own command >>> interpreter which is orthogonal to the shells, so it seems confusing to use >>> the same term for both. >> >> I think `platform shell --shell` sounds/looks repetitive so I opted for >> `-i|--interpreter` instead, as in Command-line **Interpreter**. > > Yes, it is repetitive. OTOH: > > - the unix commands that take a shell as an argument (e.g., `su`, `sudo`), do > so via a --shell/-s argument > - we have a `memory load --load` command > > Overall, I can understand where you're coming from, but I think I'd go with > --shell nonetheless... I'd agree, process launch already takes a -c|--shell argument so it would be consistent to do that. (I assume -c was used because it's kind of like sh(1)'s -c option but not really. maybe more likely that -s was already used ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86667/new/ https://reviews.llvm.org/D86667 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
