This revision was automatically updated to reflect the committed changes. Closed by commit rGdfc72439529c: [lldb] Don't add no-sandbox entitlement when running tests on simulator (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89052/new/ https://reviews.llvm.org/D89052 Files: lldb/packages/Python/lldbsuite/test/builders/darwin.py lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist Index: lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist =================================================================== --- /dev/null +++ lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd";> +<plist version="1.0"> +<dict> + <key>com.apple.security.get-task-allow</key> + <true/> +</dict> +</plist> Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py =================================================================== --- lldb/packages/Python/lldbsuite/test/builders/darwin.py +++ lldb/packages/Python/lldbsuite/test/builders/darwin.py @@ -65,11 +65,15 @@ if configuration.dsymutil: args['DSYMUTIL'] = configuration.dsymutil - operating_system, _ = get_os_and_env() + operating_system, env = get_os_and_env() if operating_system and operating_system != "macosx": builder_dir = os.path.dirname(os.path.abspath(__file__)) test_dir = os.path.dirname(builder_dir) - entitlements = os.path.join(test_dir, 'make', 'entitlements.plist') + if env == "simulator": + entitlements_file = 'entitlements-simulator.plist' + else: + entitlements_file = 'entitlements.plist' + entitlements = os.path.join(test_dir, 'make', entitlements_file) args['CODESIGN'] = 'codesign --entitlements {}'.format( entitlements)
Index: lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist =================================================================== --- /dev/null +++ lldb/packages/Python/lldbsuite/test/make/entitlements-simulator.plist @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd";> +<plist version="1.0"> +<dict> + <key>com.apple.security.get-task-allow</key> + <true/> +</dict> +</plist> Index: lldb/packages/Python/lldbsuite/test/builders/darwin.py =================================================================== --- lldb/packages/Python/lldbsuite/test/builders/darwin.py +++ lldb/packages/Python/lldbsuite/test/builders/darwin.py @@ -65,11 +65,15 @@ if configuration.dsymutil: args['DSYMUTIL'] = configuration.dsymutil - operating_system, _ = get_os_and_env() + operating_system, env = get_os_and_env() if operating_system and operating_system != "macosx": builder_dir = os.path.dirname(os.path.abspath(__file__)) test_dir = os.path.dirname(builder_dir) - entitlements = os.path.join(test_dir, 'make', 'entitlements.plist') + if env == "simulator": + entitlements_file = 'entitlements-simulator.plist' + else: + entitlements_file = 'entitlements.plist' + entitlements = os.path.join(test_dir, 'make', entitlements_file) args['CODESIGN'] = 'codesign --entitlements {}'.format( entitlements)
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
