wallace added inline comments.
================
Comment at: llvm/include/llvm/Support/Error.h:1016
+/// expected-producer might be more clearly refactored to return an
Optional<T>.
+template <typename T> inline void consumeExpected(Expected<T> E) {
+ if (!E)
----------------
vsk wrote:
> Probably best to not add another escape-hatch to permit fast and loose error
> handling. This seems to be used in a lambda passed to TraverseInstructions.
> There might be a way to avoid invoking the callback in the case where the
> expected value is thrown away.
Sure, will remove this
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89283/new/
https://reviews.llvm.org/D89283
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
