jankratochvil created this revision.
jankratochvil added a reviewer: labath.
jankratochvil added a project: LLDB.
Herald added subscribers: JDevlieghere, kristof.beyls.
jankratochvil requested review of this revision.
Is `return {...};` implicit ctor OK for LLDB? I have found only one line
(`return {sdk};`) in rG5935227e11f5
<https://reviews.llvm.org/rG5935227e11f5b8e7111ee4a076c10a62d0648689> using
that syntax and I would normally use it everywhere.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89875
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
@@ -166,7 +166,7 @@
void SetBaseAddress(dw_addr_t base_addr);
- DWARFBaseDIE GetUnitDIEOnly() { return DWARFDIE(this, GetUnitDIEPtrOnly()); }
+ DWARFBaseDIE GetUnitDIEOnly() { return {this, GetUnitDIEPtrOnly()}; }
DWARFDIE DIE() { return DWARFDIE(this, DIEPtr()); }
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
@@ -166,7 +166,7 @@
void SetBaseAddress(dw_addr_t base_addr);
- DWARFBaseDIE GetUnitDIEOnly() { return DWARFDIE(this, GetUnitDIEPtrOnly()); }
+ DWARFBaseDIE GetUnitDIEOnly() { return {this, GetUnitDIEPtrOnly()}; }
DWARFDIE DIE() { return DWARFDIE(this, DIEPtr()); }
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
