This revision was automatically updated to reflect the committed changes.
Closed by commit rG66ae40ebfb83: [lldb][test] Remove not_remote_testsuite_ready
in favor of skipIfRemote… (authored by teemperor).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89376/new/
https://reviews.llvm.org/D89376
Files:
lldb/packages/Python/lldbsuite/test/decorators.py
lldb/test/API/commands/process/launch/TestProcessLaunch.py
lldb/test/API/functionalities/load_unload/TestLoadUnload.py
lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
lldb/test/API/python_api/target/TestTargetAPI.py
Index: lldb/test/API/python_api/target/TestTargetAPI.py
===================================================================
--- lldb/test/API/python_api/target/TestTargetAPI.py
+++ lldb/test/API/python_api/target/TestTargetAPI.py
@@ -333,7 +333,7 @@
self.expect(desc, exe=False,
substrs=['Target', 'Module', 'a.out', 'Breakpoint'])
- @not_remote_testsuite_ready
+ @skipIfRemote
@add_test_categories(['pyapi'])
@no_debug_info_test
@skipIfReproducer # Inferior doesn't run during replay.
Index: lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
===================================================================
--- lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
+++ lldb/test/API/functionalities/process_save_core/TestProcessSaveCore.py
@@ -14,7 +14,7 @@
mydir = TestBase.compute_mydir(__file__)
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipUnlessWindows
def test_cannot_save_core_unless_process_stopped(self):
"""Test that SaveCore fails if the process isn't stopped."""
@@ -28,7 +28,7 @@
error = process.SaveCore(core)
self.assertTrue(error.Fail())
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipUnlessWindows
def test_save_windows_mini_dump(self):
"""Test that we can save a Windows mini dump."""
Index: lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
===================================================================
--- lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
+++ lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
@@ -36,7 +36,7 @@
self.hidden_dir = os.path.join(self.wd, 'hidden')
self.hidden_lib = os.path.join(self.hidden_dir, self.lib_name)
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
@expectedFlakeyNetBSD
@expectedFailureAll(oslist=["linux"], archs=['arm'], bugnumber="llvm.org/pr45894")
Index: lldb/test/API/functionalities/load_unload/TestLoadUnload.py
===================================================================
--- lldb/test/API/functionalities/load_unload/TestLoadUnload.py
+++ lldb/test/API/functionalities/load_unload/TestLoadUnload.py
@@ -91,7 +91,7 @@
# libloadunload_d.so does not appear in the image list because executable
# dependencies are resolved relative to the debuggers PWD. Bug?
@expectedFailureAll(oslist=["freebsd", "linux", "netbsd"])
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipIfWindows # Windows doesn't have dlopen and friends, dynamic libraries work differently
@skipIfReproducer # VFS is a snapshot.
def test_modules_search_paths(self):
Index: lldb/test/API/commands/process/launch/TestProcessLaunch.py
===================================================================
--- lldb/test/API/commands/process/launch/TestProcessLaunch.py
+++ lldb/test/API/commands/process/launch/TestProcessLaunch.py
@@ -28,7 +28,7 @@
self.runCmd("settings clear auto-confirm")
TestBase.tearDown(self)
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipIfReproducer
def test_io(self):
"""Test that process launch I/O redirection flags work properly."""
@@ -82,7 +82,7 @@
# rdar://problem/9056462
# The process launch flag '-w' for setting the current working directory
# not working?
- @not_remote_testsuite_ready
+ @skipIfRemote
@expectedFailureAll(oslist=["freebsd", "linux"], bugnumber="llvm.org/pr20265")
@expectedFailureNetBSD
@skipIfReproducer
@@ -112,7 +112,7 @@
"error:.* No such file or directory: %s" %
invalid_dir_path])
- @not_remote_testsuite_ready
+ @skipIfRemote
@skipIfReproducer
def test_set_working_dir_existing(self):
"""Test that '-w dir' sets the working dir when running the inferior."""
Index: lldb/packages/Python/lldbsuite/test/decorators.py
===================================================================
--- lldb/packages/Python/lldbsuite/test/decorators.py
+++ lldb/packages/Python/lldbsuite/test/decorators.py
@@ -390,13 +390,6 @@
return skipTestIfFn(should_skip_llgs_tests)(func)
-def not_remote_testsuite_ready(func):
- """Decorate the item as a test which is not ready yet for remote testsuite."""
- def is_remote():
- return "Not ready for remote testsuite" if lldb.remote_platform else None
- return skipTestIfFn(is_remote)(func)
-
-
def expectedFailureOS(
oslist,
bugnumber=None,
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
