labath accepted this revision. labath added a subscriber: omjavaid. labath added a comment. This revision is now accepted and ready to land.
Looks good to me. @omjavaid, could you take a quick look at the invalidate/contained register lists? ================ Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:84-97 + lldb_fop_x86_64, lldb_fiseg_x86_64, lldb_fioff_x86_64, + lldb_fip_x86_64, lldb_foseg_x86_64, lldb_fooff_x86_64, + lldb_fdp_x86_64, lldb_mxcsr_x86_64, lldb_mxcsrmask_x86_64, + lldb_st0_x86_64, lldb_st1_x86_64, lldb_st2_x86_64, + lldb_st3_x86_64, lldb_st4_x86_64, lldb_st5_x86_64, + lldb_st6_x86_64, lldb_st7_x86_64, lldb_mm0_x86_64, + lldb_mm1_x86_64, lldb_mm2_x86_64, lldb_mm3_x86_64, ---------------- lol@diff ================ Comment at: lldb/test/Shell/Register/x86-64-fp-read.test:11-12 +# CHECK: (void *) $0 = [[FDIV:0x[0-9a-f]*]] +print (void*)($fiseg*0x100000000 + $fioff) +# CHECK: (void *) $1 = [[FDIV]] +print &zero ---------------- mgorny wrote: > labath wrote: > > Move this part after the `fip` check and add a comment to indicate its > > legacy/compat status? > I suppose it also makes sense to remove the fiseg/fioff logic from the 32-bit > `x86-fp-read.test`, as it is only relevant to the FXSAVE64 approach. Yep, sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91497/new/ https://reviews.llvm.org/D91497 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits