labath added a reviewer: jasonmolenda.
labath added a comment.

Thanks for doing this. The changes look pretty straight-forward.

The main thing I think is missing here is the shelltest equivalent of 
`@skipIfOutOfTreeDebugserver` -- most people build/test lldb with the system 
debug server (because, reasons...) and so the test will still fail in those 
configurations...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91847/new/

https://reviews.llvm.org/D91847

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to