mgorny added a comment. In D91504#2407397 <https://reviews.llvm.org/D91504#2407397>, @labath wrote:
> Well... I think that will make the test fail on mac, as debugserver hasn't > been updated. > > This test comes from D12592 <https://reviews.llvm.org/D12592>, and is > actually serves a very similar purpose to the test you just wrote. Normally, > I would say we don't need both of them, but since we still have debugserver > with the old behavior, and your new test is consistent with how we've > (you've) been writing other register tests, maybe we could just slap > `@skipUnlessDarwin` on TestRegisters.py, and put some comments (on both > tests) that explain the situation and cross-reference each other (?) I could do that. I suppose it'd also be reasonably easy to make the Python test support both platforms with an `if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91504/new/ https://reviews.llvm.org/D91504 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
