On 14/11/2020 02:39, Jonas Devlieghere via lldb-commits wrote:
+# RUN: echo -e 'platform select remote-gdb-server\nprocess connect connect://localhost:4321' | %lldb 2>&1 | FileCheck %s + +# CHECK: Platform: remote-gdb-server +# CHECK: Connected: no +# CHECK: error: Failed to connect port
This is a bad test. You can't assume that the host machine will not have port 4321 open. If it does, for some reason, the test will fail. Moreover, if that port happens to belong to some other test (not likely, as we normally use higher port numbers, but possible), the spurious connection cause *that* test to fail as well...
(We've observed flakyness in this test internally. While I don't have conclusive proof that this is the cause, it's a pretty good bet that it is.)
The right way to handle this would be to first claim a port, and then have lldb server connect to that port. (most likely requires writing the test in python.)
pl _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
