rovka added a comment. Sorry, I had one more comment :) I think that should be all from my side.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:403 + m_register_info_sp = std::make_shared<GDBRemoteDynamicRegisterInfo>(); + m_register_info_sp->Clear(); ---------------- Is it still necessary to call Clear? I think the default constructor should give us a "cleared" object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
