MaskRay added a comment. In D94890#2505988 <https://reviews.llvm.org/D94890#2505988>, @labath wrote:
> Looks like a nice cleanup. The only part I am not sure of is the part about > removing `$(RM) $(ARCHIVE_OBJECTS)`. Is that necessary? > I'm not sure why is that line there, but if I had to guess, I would say it's > to ensure that lldb (on macos) reads debug info from the archive file instead > of the original .o files. If it's not required, it may be better to leave it > in. Otherwise, someone from Apple should say whether that is ok (testing > archives is only really interesting on fruity platforms). I can add back it under the `ifeq "$(OS)" "Darwin"` guard if Apple folks think it is useful. > BTW, have you measured any speedups from these improvements? I don't notice a difference in `check-lldb-api`'s `Testing Time: `. I think the time is probably dominated by running lldb and Python.. If the user builds `-DBUILD_SHARED_LIBS=on` clang and thus has a significant startup overhead, I guess there may be some differences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94890/new/ https://reviews.llvm.org/D94890 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
