aadsm added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1558
+ if (!launchCommands.empty()) {
+ // if "launchCommands" are provided, then they are expected to make the
+ // launch happen for launch requests and they replace the normal logic that
----------------
clayborg wrote:
> We need to check if any arguments are set in the launch config that
> "launchCommands" will ignore and return an error if any of them are set. Or
> we need to emit an error or warning to the debug console so the users can
> know that these settings are now ignored because "launchCommands" will cause
> them to be.
I vote for a warning here otherwise it might break people's current setups,
assuming the error is an indication that the launch won't happen, but we should
totally do it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94997/new/
https://reviews.llvm.org/D94997
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
