[Lldb-commits] [PATCH] D96939: [lldb] Add a note to the core file loading error message that mentions archives

[Raphael Isemann via Phabricator via lldb-commits]

teemperor updated this revision to Diff 324546.
teemperor added a comment.

- Made `note:` lower case


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96939/new/

https://reviews.llvm.org/D96939

Files:
  lldb/source/Commands/CommandObjectTarget.cpp


Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -427,6 +427,10 @@
           result.AppendErrorWithFormatv(
               "Unable to find process plug-in for core file '{0}'\n",
               core_file.GetPath());
+          result.AppendMessage(
+              "note: If the passed file is a compressed file archive 
containing"
+              " a core file, you first need to manually extract the core file "
+              " from the archive before trying to load it.\n");
           result.SetStatus(eReturnStatusFailed);
         }
       } else {



Index: lldb/source/Commands/CommandObjectTarget.cpp
===================================================================
--- lldb/source/Commands/CommandObjectTarget.cpp
+++ lldb/source/Commands/CommandObjectTarget.cpp
@@ -427,6 +427,10 @@
           result.AppendErrorWithFormatv(
               "Unable to find process plug-in for core file '{0}'\n",
               core_file.GetPath());
+          result.AppendMessage(
+              "note: If the passed file is a compressed file archive containing"
+              " a core file, you first need to manually extract the core file "
+              " from the archive before trying to load it.\n");
           result.SetStatus(eReturnStatusFailed);
         }
       } else {

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits