smeenai added a comment. My understanding of the issue is that, with the runtimes build, the `cxx` target will get created after we process LLDB's build files. The `TARGET cxx` check here will therefore fail, but the `cxx` target will end up existing later, and CMake is perfectly fine adding a dependency to a target that gets created later, so the failing check is spurious. The `libcxx IN_LIST LLVM_ENABLE_RUNTIMES` is basically a proxy for "the `cxx` target doesn't exist right now but will exist later". Could you add an explanation of the issue to the summary or the code comment?
(Note that if you change a commit message locally, `arc diff` won't update the summary of this review by default ... you'll need `arc diff --verbatim` to make it update the summary.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97227/new/ https://reviews.llvm.org/D97227 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
