labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
I remember seeing this that this (duplicated) code was not dwarf5 ready, but I did not want to change it without understanding when it actually gets used. It looks like you've found that. Thanks for doing that, and for removing the duplication. ================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-debug_line-file-index.s:98 + .byte 86 + .byte 3 # DW_AT_name + .byte 0 # DW_AT_decl_file ---------------- I was puzzled by this line as the string 3 is nowhere to be found. I take it this was manually reduced? If so, I think you should be able to delete the entire subprogram and base_type tags (and the relevant abbreviations), as that is not necessary for the line tables to work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98619/new/ https://reviews.llvm.org/D98619 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
