teemperor added a comment.
The tests are failing because Dave's bot is running without enabled Python. The
same is true for the Windows bot. Putting the plugin behind `#ifdef
LLDB_ENABLE_PYTHON` should fix this.
FWIW, even with enabled Python this seems to have some minor problems with
command parsing:
FAIL: test_double_type_dwo (TestDoubleTypes.DoubleTypesTestCase)
Test that double-type variables are displayed correctly.
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/teemperor/work/ci/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 1846, in test_method
return attrvalue(self)
File
"/home/teemperor/work/ci/llvm-project/lldb/test/API/types/TestDoubleTypes.py",
line 21, in test_double_type
self.build_and_run('double.cpp', set(['double']))
File
"/home/teemperor/work/ci/llvm-project/lldb/test/API/types/AbstractBase.py",
line 67, in build_and_run
self.build_and_run_with_source_atoms_expr(
File
"/home/teemperor/work/ci/llvm-project/lldb/test/API/types/AbstractBase.py",
line 88, in build_and_run_with_source_atoms_expr
self.generic_type_tester(
File
"/home/teemperor/work/ci/llvm-project/lldb/test/API/types/AbstractBase.py",
line 145, in generic_type_tester
self.process_launch_o()
File
"/home/teemperor/work/ci/llvm-project/lldb/test/API/types/AbstractBase.py",
line 111, in process_launch_o
self.runCmd(
File
"/home/teemperor/work/ci/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 2176, in runCmd
self.assertTrue(self.res.Succeeded(),
AssertionError: False is not True : Command 'process launch -o
"/home/teemperor/work/ci/build/lldb-test-build.noindex/types/TestDoubleTypes.test_double_type_dwo/test_double_type_dwo-golden-output.txt"
Error output:
error: invalid combination of options for the given command
' did not return successfully
(This is with enabled Python)
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:61
+ : Process(target_sp, listener_sp), m_launch_info(launch_info),
+ m_interpreter(nullptr), m_script_object_sp(nullptr) {
+ if (!target_sp)
----------------
You probably want to use default initializers in the header for this stuff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95713/new/
https://reviews.llvm.org/D95713
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
