teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the patch (and especially the unit test)! Some two nits left
but feel free to fix those when merging. If you don't have commit access I can
also do that, just let me know.
================
Comment at: lldb/include/lldb/Core/FormatEntity.h:120
+ /// Whether the separator is kept during parsing or not (used
+ /// for entries with parameters)
+ const bool keep_separator = false;
----------------
Missing period
================
Comment at: lldb/unittests/Core/FormatEntityTest.cpp:154
+TEST(FormatEntity, LookupAllEntriesInTree) {
+ for (const auto &testString : lookupStrings) {
+ Entry e;
----------------
teemperor wrote:
> You could just use `llvm::StringRef` here (it's shorter and more descriptive
> than the `auto`).
I actually meant `llvm::StringRef` as the whole type (StringRef references are
not really useful as StringRef is already a lightweight String reference)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98153/new/
https://reviews.llvm.org/D98153
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
