dblaikie added inline comments.
================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:11
+# Failure was the block range 1..2 was not printed plus:
+# error: DW_AT_range-DW_FORM_sec_offset.s.tmp {0x0000003f}: DIE has
DW_AT_ranges(0xc) attribute, but range extraction failed (missing or invalid
range list table), please file a bug and attach the file at the start of this
error message
+
----------------
I'm not sure if `%t` is guaranteed to produce a file name with that
format/name. So maybe using `{{.*}}` for the file name (and `{{.*}}-rnglistx`
below) would be a bit more stable
================
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:32
+# RNGLISTBASE-LABEL: image lookup -v -s lookup_rnglists
+# RNGLISTBASE: error: DW_AT_range-DW_FORM_sec_offset.s.tmp-rnglistbase
{0x00000043}: DIE has DW_AT_ranges(0x0) attribute, but range extraction failed
(invalid range list table index 0), please file a bug and attach the file at
the start of this error message
+
----------------
Perhaps this could be more informative about what makes the range list index of
0 invalid? "index 0 out of range of range list table (with range list base
0xXXX) with offset entry count of XX (valid indexes 0-(XX-1))" Maybe that's too
verbose/not worth worrying about since this'll only be relevant to DWARF
producers trying to debug their DWARFv5, maybe no one will ever see this
message in practice. Just a thought.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98289/new/
https://reviews.llvm.org/D98289
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
