JDevlieghere added a subscriber: kastiglione. JDevlieghere added a comment.
In D91508#2698704 <https://reviews.llvm.org/D91508#2698704>, @teemperor wrote: > I think this might have broken the Windows build as it seems the > LLDBSwigLuaBreakpointCallbackFunction return type is an error for MSVC (and > not a warning which we seem to ignore locally). > > To quote someone from the Discord server: > > I'm getting the following build error when attempting to build 12.0.0 using > Microsoft CL 19.28.29913 for x64: > > C:\llvm-build\llvm-project-12.0.0\lldb\source\Plugins\ScriptInterpreter\Lua\Lua.cpp(29): > error C2526: 'LLDBSwigLuaBreakpointCallbackFunction': C linkage function > cannot return C++ class 'llvm::Expected<bool>' > > C:\llvm-build\llvm-project-12.0.0\lldb\source\Plugins\ScriptInterpreter\Lua\Lua.h(36): > note: see declaration of 'llvm::Expected<bool>' > > C:\llvm-build\llvm-project-12.0.0\lldb\source\Plugins\ScriptInterpreter\Lua\Lua.cpp(112): > error C2440: 'return': cannot convert from 'void' to 'llvm::Expected<bool>' @kastiglione isn't this the error you fixed for Python? Should we do the same for Lua? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91508/new/ https://reviews.llvm.org/D91508 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
