mib marked an inline comment as done. mib added inline comments.
================ Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:184 + FileSpec m_file_spec; + uint32_t m_line; + llvm::Optional<uint16_t> m_column; ---------------- JDevlieghere wrote: > Are there situations where the line is optional too? Technically, `m_line` could be equal to 0 (if there is no line information) but that would basically mean this class is a `FileSpec` container. I guess I can add an assert in the constructor checking if it's not null. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100962/new/ https://reviews.llvm.org/D100962 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
