teemperor added a comment. If anyone feels like any of the guidelines is actually controversial then let me know and I'll remove it from this review and split it out into its own patch.
(I am also aware that the text directly above has some small overlap with the guidelines as it for example also recommends the lldb utility functions for setup/checking. But given how frequently this comes up in patches I just put it in as its own guideline). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits