rupprecht added a comment. In D97786#2693410 <https://reviews.llvm.org/D97786#2693410>, @jingham wrote:
> In D97786#2693381 <https://reviews.llvm.org/D97786#2693381>, @cmtice wrote: > >> I had to revert this change because the test case broke the windows builder. >> What's the right way to update/mark the test case so that it is only run on >> appropriate architectures & operating systems? > > You add the python skipIfWindows "decorator" before each test case > definition. Just grep around in the test/API directory and you'll see plenty > of instances of its use. Since this is a shell (lit) test, I think you mean adding `# REQUIRES: windows` at the top of the test? > This does seem like it should work on Windows, however. Maybe some path > handling problem? This would be my guess too. But the APIs used here seem to handle file paths generically... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
