labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
I like this, though I am still unsure about the reason for existence of the "multiprocess" extension. ================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:287 + return Extension::multiprocess | Extension::fork | Extension::vfork | + Extension::pass_signals | Extension::auxv | Extension::libraries_svr4; } ---------------- Technically, `libraries_svr4` functionality is implemented in the base class, so it would be more correct to implement this as `| NativeProcessELF::Factory::GetSupportedExtensions()` (this would be a new class, which exists only to override `GetSupportedExtensions`). ================ Comment at: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py:977 + @skipUnlessPlatform(["freebsd", "linux", "netbsd"]) + def test_qSupported_auvx(self): ---------------- I guess it would be even better to run this everywhere, but assert that the server returns the right value for the particular platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101241/new/ https://reviews.llvm.org/D101241 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
