teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM but could you split out the non-NFC change (and then you can also mark this whole commit as NFC). I'm just going to accept this module that change. ================ Comment at: lldb/source/API/SBDebugger.cpp:164 uint64_t &total, - bool &is_debugger_specific) { + bool &is_debugger_specific) {LLDB_RECORD_STATIC_METHOD(const char *, SBDebugger, GetProgressFromEvent, (const lldb::SBEvent &, uint64_t &, uint64_t &, uint64_t &, bool &), event, progress_id, completed, total, is_debugger_specific); + ---------------- Can you clang-format and move this into its own patch (it's not really a NFC typo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103381/new/ https://reviews.llvm.org/D103381 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits