This revision was automatically updated to reflect the committed changes. Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104047/new/ https://reviews.llvm.org/D104047 Files: lldb/source/API/CMakeLists.txt Index: lldb/source/API/CMakeLists.txt =================================================================== --- lldb/source/API/CMakeLists.txt +++ lldb/source/API/CMakeLists.txt @@ -182,13 +182,7 @@ set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc") endif() -if (MSVC) - # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs, - # so only it needs to explicitly link against ${Python3_LIBRARIES} - if (LLDB_ENABLE_PYTHON) - target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES}) - endif() -else() +if (NOT MSVC) set_target_properties(liblldb PROPERTIES OUTPUT_NAME lldb
Index: lldb/source/API/CMakeLists.txt =================================================================== --- lldb/source/API/CMakeLists.txt +++ lldb/source/API/CMakeLists.txt @@ -182,13 +182,7 @@ set_target_properties(liblldb_exports PROPERTIES FOLDER "lldb misc") endif() -if (MSVC) - # Only MSVC has the ABI compatibility problem and avoids using FindPythonLibs, - # so only it needs to explicitly link against ${Python3_LIBRARIES} - if (LLDB_ENABLE_PYTHON) - target_link_libraries(liblldb PRIVATE ${Python3_LIBRARIES}) - endif() -else() +if (NOT MSVC) set_target_properties(liblldb PROPERTIES OUTPUT_NAME lldb
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits