teemperor added inline comments.
================
Comment at: lldb/unittests/Core/MangledTest.cpp:72
+
+ EXPECT_STREQ("", TheDemangled.GetCString());
+}
----------------
asm wrote:
> teemperor wrote:
> > Could you do me a favour and change your test functions to LLDB's code
> > style, so `mangled_name` as a variable name instead of `MangledName` and so
> > on.
> >
> > I'm aware the rest of the file is already using LLVM code style, but I
> > think that's was just an oversight. I'll probably change the code style in
> > this file to LLDB's and it would keep the git history a bit simpler.
> Sure no problem. This is my first contribution to LLVM. I just mimicked the
> code around.
>
> Just to check I understand. You're looking for something like this?
>
> ```
> ConstString manged_lname("_RRR");
> Mangled the_mangled(mangled_name);
> ConstString the_demangled = the_mangled.GetDemangledName();
>
> EXPECT_STREQ("", the_demangled.GetCString());
> ```
Jepp, that's the LLDB code style! Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104054/new/
https://reviews.llvm.org/D104054
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
