shafik added inline comments.
================
Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.h:104
+ // We also return the FunctionNameType of each possible name.
+ std::vector<std::pair<ConstString, lldb::FunctionNameType>>
GetMethodNameVariants(ConstString method_name) const override;
----------------
teemperor wrote:
> Could we make this a custom struct? `first` `second` are always so
> non-descriptive and we might want to extend what we return from this function
> in a future patch.
>
> ```
> lang=c++
> class MethodNameVariant {
> ConstString m_name;
> lldb::FunctionNameType m_type;
> public:
> [...]
> }```
I second (pun intended?) this, if we can avoid using `std::pair` and instead
use a custom struct we should.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104067/new/
https://reviews.llvm.org/D104067
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
