clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Lets try the diamond character for the boolean stuff unless anyone has any
objections. Maybe handle a few more keys for the boolean field as suggested in
the comments. This will be good to go after these changes!
================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:960
+
+ int GetContentLength() { return (int)m_content.length(); }
+
----------------
It is fine to leave cast to int if this is causing compiler warnings. Many
things are integers in the curses API.
================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1104
+ }
+
+ // [X] Label or [ ] Label
----------------
I like the diamond one personally. Looks nice and clean
================
Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1121
+
+ HandleCharResult FieldDelegateHandleChar(int key) override {
+ switch (key) {
----------------
maybe handle '1' to set m_content to true and '0' to set to false? Could also
handle 't' for true and 'f' for false?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104395/new/
https://reviews.llvm.org/D104395
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
