aprantl added a comment.
I think it would be best to split out the Clang change into a separately tested
patch.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693
+ if (!try_resolving_type)
+ return true;
+
----------------
This block looks like it's more complicated than it needs to be. Could you just
say
```
if (other_die != die)
if (other_die.Tag()) != DW_TAG_subprogram)
return false;
```
or am I missing something?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105564/new/
https://reviews.llvm.org/D105564
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
