DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This is a response to feedback on https://reviews.llvm.org/D105181 but would be intended to come before any of the changes in that series if it looks good.
I'm yet to refactor the tag writing changes on to this, wanted to get some feedback first. Roughly tag writing would instead of adding `GetMemoryTagManagerForGranules` to process, it would add `MakeTaggedRangeForGranules` to the tag manager. Then the `memory tag write` command calls that instead of relying on `GetMemoryTagManager` to implement that logic. Then Process simply has `GetMemoryTagManager`, `ReadMemoryTags` and `WriteMemoryTags`. Instead of growing all these variants of `GetMemoryTagManager`. Side note: I actually found a bug when writing the unit tests, so I think that's a big plus to this approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
