wallace added inline comments.
================ Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:121 /// stopped at. See \a Trace::GetCursorPosition for more information. -class DecodedThread { +class DecodedThread : public std::enable_shared_from_this<DecodedThread> { public: ---------------- clayborg wrote: > You only need to inherit from "std::enable_shared_from_this" if you ever need > to take a "DecodedThread *" and get ahold of the original > std::shared_ptr<DecodedThread>. Is that the case here? i'm using it for calling shared_from_this inside DecodedThread.cpp, which is very handy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105531/new/ https://reviews.llvm.org/D105531 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits