OmarEmaraDev added a comment.
Herald added a subscriber: JDevlieghere.

I initially created two forms for attach by name and attach by PID, because the 
options were divided between them. Today I tried to reimplement that such that 
it is a single form with a choices field at the top that determines if it is by 
name or PID. The fields are then shown or hidden based on that enum. 
Additionally, other fields can control the visibility of other fields, for 
instance, the "Include existing processes" field. I think it works fine and the 
UX looks good. Here is an example, what do you think?

F17834972: 20210708-223744.mp4 <https://reviews.llvm.org/F17834972>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105655/new/

https://reviews.llvm.org/D105655

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to