aprantl added inline comments.
================ Comment at: lldb/source/Target/ThreadPlanStack.cpp:145 - lldb::ThreadPlanSP plan_sp = std::move(m_plans.back()); + lldb::ThreadPlanSP plan_sp = m_plans.back(); + m_plans.pop_back(); ---------------- Should we comment that we are intentionally making a copy of the SP to avoid a race condition with std::move()? ================ Comment at: lldb/source/Target/ThreadPlanStack.cpp:146 + lldb::ThreadPlanSP plan_sp = m_plans.back(); + m_plans.pop_back(); m_completed_plans.push_back(plan_sp); ---------------- It's counterintuitive that WillPop() is being called *after* the value is popped now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106171/new/ https://reviews.llvm.org/D106171 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
